Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure when no input+select+textarea #15

Closed
Javarome opened this issue Nov 4, 2013 · 1 comment
Closed

Failure when no input+select+textarea #15

Javarome opened this issue Nov 4, 2013 · 1 comment

Comments

@Javarome
Copy link

Javarome commented Nov 4, 2013

The setupExtraFeatures() code iterates on available input, select and textarea and sets a node for each. But if none is found node remains undefined and node.type is attempted on an undefined value.

While some recent browsers will only display "Uncaught TypeError: Cannot read property 'type' of undefined", oldest ones will just stop on such a failure.

Moreover, the code indicates that this will occur unless at least one instance of each type (input, select and textarea) is found in the document.

It would be better if node is checked before the test and if start could not be called automatically (on a 'ready' event if fields are dynamically added)

@zoltan-dulac
Copy link
Owner

This has been fixed by #16 . Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants